Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core/dev#692 : Unable to use url search arguments in 'Advanced Search' using force=1 #13651

Closed
wants to merge 2 commits into from

Conversation

monishdeb
Copy link
Member

Overview

Currently, it is not possible to use URL search arguments in 'Advanced Search' using force=1 to load search results. This is no longer working except for mailing params which are manually handled here

Before

You cannot use any search parameters as url arguments to load search results in 'Advance Search'.

After

You cannot use contact search parameters as url arguments to load search results in 'Advanced Search'. Here are two examples:

  1. Using contact_type=Individual
    before

  2. Log date = true AND log_date_relative = This calendar month
    after

  3. Privacy options - do_not_email + privacy operator - AND + privacy toggle - Include
    after

Technical Details

This fix is made for Contact search fields and can be extended for other component's search forms.
Please check the issue description here for more details.

Comments

ping @lcdservices @eileenmcnaughton @seamuslee001

@civibot
Copy link

civibot bot commented Feb 20, 2019

(Standard links)

@civibot civibot bot added the master label Feb 20, 2019
eileenmcnaughton added a commit to eileenmcnaughton/civicrm-core that referenced this pull request May 26, 2019
I picked this up as a reviewer's commit of civicrm#13651

That PR is stale but I like to pick out a bit I can get merged when closing a stale pr
eileenmcnaughton added a commit to eileenmcnaughton/civicrm-core that referenced this pull request May 26, 2019
I picked this up as a reviewer's commit of civicrm#13651

That PR is stale but I like to pick out a bit I can get merged when closing a stale pr
@eileenmcnaughton
Copy link
Contributor

@monishdeb closing this for now as it's stale. I pulled the first few lines into a reviewer's commit to get them merged.

There is a lot in here - what about just doing a small PR for the extraction of one of the metadata functions & we can progress it in smaller chunks?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants