Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove another instance of 'lower' #13636

Merged
merged 1 commit into from
Feb 19, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Minor tidy up / obscure perfomance enhancement when searching on notes on a contribution

Before

LOWER used

After

LOWER gone

Technical Details

We have removed almost all of these from the code base due to the performance cost
combined with the lack of any upside. Just found another

Comments

We have removed almost all of these from the code base due to the performance cost
combined with the lack of any upside. Just found another
@civibot
Copy link

civibot bot commented Feb 19, 2019

(Standard links)

@colemanw
Copy link
Member

Adding merge-on-pass based on code review and similarity to other improvements along these same lines.

@seamuslee001
Copy link
Contributor

Merging as per the tag

@seamuslee001 seamuslee001 merged commit a0c5337 into civicrm:master Feb 19, 2019
@seamuslee001 seamuslee001 deleted the strtolower branch February 19, 2019 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants