Standardize format for entityRef create links #13628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
| foreach (CRM_Contact_BAO_ContactType::basicTypes() as $contactType) { | ||
| $profiles[] = 'new_' . strtolower($contactType); | ||
| } | ||
| $retrieved = civicrm_api3('uf_group', 'get', [ |
There was a problem hiding this comment.
FWIW - I've taken to using the newer format where you stick ['values'] on the end & then don't need to unpack from values
|
I've worked through this code & done a couple of UI tests on create contribution using entity Ref & create from shared address & it works for me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This continues some refactoring done in #13625 and #13491 to make entityRef links easier for developers to work with.
Before
Create links for contacts were given special treatment and were pre-loaded to the clientside. Others had to be loaded at runtime.
After
All links treated the same and pre-loaded to the clientside so that they work equally well with all entities.
Technical Details
This should make the code easier to understand and also will make entityRef widgets easier to add dynamically e.g. with Angular-based pages.