Deprecate generating recipients from MailingJob

[eileenmcnaughton]

Overview

Deprecate generating recipients from MailingJob

Before

No deprecation notice when calling MailingJob::create with mailing_id (which results in the recipient list being generated, and is the reason this function is generally bypassed)

After

Deprecation notice

Technical Details

Every place in the code that would sensibly call this BAO / api create function ...
doesn't - presumably because it does something generally done elsewhere.

Deprecating it will enable us to remove it later & allow this create fn & associated
hooks to be called

generating the list when not required causes deep performance badness

Comments

Am expecting syntaxconformance fails - assuming 'mailing_id' gets through from there - will address as they arise

#12231

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

test this please

[monishdeb]

@eileenmcnaughton seems like you have not included the UT fix?

[eileenmcnaughton]

@monishdeb I started on them - got a change merged that fixed one of them

[eileenmcnaughton]

This is kinda the meaty one

api_v3_MailingTest::testMailerSendTest_email
Failure in api call for Mailing send_test:  Deprecated function CRM_Mailing_BAO_MailingJob::create, use call getRecipients from calling function.
Array
(
    [civi.tag] => deprecated
)

In that it's the one place I think the send-from-create-job is used but I think calling the send from sendtest makes sense here