Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove tests that no longer work due to dead service #13617

Merged
merged 1 commit into from
Feb 17, 2019
Merged

Remove tests that no longer work due to dead service #13617

merged 1 commit into from
Feb 17, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Remove test that no longer pass due to external provider (google geocoding) service change

Before

tests exist & always fail

After

Tests gone

Technical Details

Can't test a service we can't use

@civibot
Copy link

civibot bot commented Feb 17, 2019

(Standard links)

@civibot civibot bot added the master label Feb 17, 2019
@eileenmcnaughton
Copy link
Contributor Author

unrelated fails

@eileenmcnaughton eileenmcnaughton merged commit c20178a into civicrm:master Feb 17, 2019
@eileenmcnaughton eileenmcnaughton deleted the no_dead_service_tests branch February 17, 2019 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master merge on pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eileenmcnaughton @colemanw