Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev/core#721 Fix regression on refreshing group_contact cache before checking acls #13597

Merged
merged 1 commit into from
Feb 14, 2019
Merged

dev/core#721 Fix regression on refreshing group_contact cache before checking acls #13597

merged 1 commit into from
Feb 14, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Feb 14, 2019 •
edited
Loading

port of #13593

@eileenmcnaughton
Fix regression on refreshing group_contact cache before checking acls
3261c27 
We seem to be checking if the cache needs a rebuild and IF SO doing 2 actions
1) rebuilding it
2) permitting access to contacts related to it

When really it should do only 1) above - this patch changes as such

This seems to be whackamole off civicrm#12344
going too far one way & civicrm#13448
fixing but adding this new variant
@civibot
Copy link

civibot bot commented Feb 14, 2019

(Standard links)

@civibot civibot bot added the 5.10 label Feb 14, 2019
@seamuslee001
Copy link
Contributor

Added Merge on pass as the 5.11 PR already has it and has been tested

@seamuslee001
Copy link
Contributor

Test fails unrelated

@seamuslee001 seamuslee001 merged commit aeb6cf0 into civicrm:5.10 Feb 14, 2019
@seamuslee001 seamuslee001 deleted the acl_reg510 branch February 14, 2019 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
5.10 merge on pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eileenmcnaughton @seamuslee001