Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improves styling on Joomla! upgrade screen #13557

Merged
merged 2 commits into from
Feb 13, 2019

Conversation

vingle
Copy link
Contributor

@vingle vingle commented Feb 10, 2019

Overview

Minor CSS padding cleanup, specific to Joomla upgrade screen, fixing a degredation from this commit (6ada1ce)

Before

Padding was removed from the main Joomla admin screen in this commit - 6ada1ce - which also removed padding on the upgrade screen.
pastedgraphic-25

After

What has been changed. Please provide screenshots or gifs (LICEcap, SilentCast) where appropriate.
image

Padding was removed from the Joomla admin screen in this commit - civicrm@6ada1ce - which removed all padding on the upgrade screen. Fix to add padding to that screen.
Fixes issue where padding was removed from the main Joomla admin screen in this commit - civicrm@6ada1ce - removing padding on the upgrade screen.
@civibot
Copy link

civibot bot commented Feb 10, 2019

(Standard links)

@civibot civibot bot added the master label Feb 10, 2019
@seamuslee001
Copy link
Contributor

ping @mattwire @lcdservices @colemanw thoughts folks?

@eileenmcnaughton eileenmcnaughton changed the title Patch 5 Improves styling on Joomla! upgrade screen Feb 10, 2019
@mattwire
Copy link
Contributor

This is targetting a specific CSS selector, is limited to Joomla only so pretty harmless. I can test this next time I upgrade but if anyone else gets there first then we can merge.

@colemanw
Copy link
Member

Aside: a lot of the stuff in joomla.css was written back in the days of Joomla 1.x and 2.x and probably no longer needs to be there.

@eileenmcnaughton
Copy link
Contributor

I'm gonna merge this since @mattwire's comment was supportive & @colemanw didn't say no. Also I think @vingle is our resident Joomla! expert & a bit of a dab hand at css :-)

@eileenmcnaughton eileenmcnaughton merged commit cbbaeae into civicrm:master Feb 13, 2019
@vingle
Copy link
Contributor Author

vingle commented Feb 14, 2019

I'm gonna merge this since @mattwire's comment was supportive & @colemanw didn't say no. Also I think @vingle is our resident Joomla! expert & a bit of a dab hand at css :-)

thanks — tho I can never fit in Brian's huge shoes! (or Matt's tbf). But I will try to look at joomla.css at some point as I sensed it could be cleaned up, now confirmed by Coleman.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants