Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Used field name defined in DAO file for Activity Subject #13530

Merged
merged 2 commits into from
Feb 4, 2019
Merged

Used field name defined in DAO file for Activity Subject #13530

merged 2 commits into from
Feb 4, 2019

Conversation

pradpnayak
Copy link
Contributor

Overview

The subject field allowed unlimited chars to input

Before

The subject field allowed unlimited chars to input

After

Restricted to size defined in DAO for Activity subject

@civibot
Copy link

civibot bot commented Feb 4, 2019

(Standard links)

@civibot civibot bot added the master label Feb 4, 2019
@colemanw
Remove redundant css class from activity subject field
46f0f1a 
This is now being automatically assigned thanks to the change in 6e9c7c7
@colemanw
Copy link
Member

colemanw commented Feb 4, 2019

Tested. This is good to merge. I've pushed a followup change to remove the redundant class.

@pradpnayak
Copy link
Contributor Author

Thanks @colemanw

@eileenmcnaughton
Copy link
Contributor

If the field hadn't already had the wrong field I probably would have pushed for switching to the addField method

@eileenmcnaughton eileenmcnaughton merged commit 631a62f into civicrm:master Feb 4, 2019
@pradpnayak pradpnayak deleted the FieldLength-Activity branch March 23, 2020 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master merge on pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pradpnayak @colemanw @eileenmcnaughton