remove duplicated call to createCreditNoteId()

[sluc23]

Overview

Remove duplicated call to CRM_Contribute_BAO_Contribution::createCreditNoteId() in CRM_Contribute_BAO_Contribution::create() method

Before

In create() method the function createCreditNoteId() is called if the Contribution to be created has status Canceled or Refunded
Then add() is called which does the exact same call

After

Only add() performs the createCreditNoteId() call

Technical Details

The exact same code is executed twice when creating/editing a Contribution in Canceled or Refunded. Removing the one in create() method

Note extended discussion in chat at https://chat.civicrm.org/civicrm/pl/7ybsucbd1tr7bdftmb94atj6mh

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[sluc23]

@monishdeb

[monishdeb]

@sluc23 nice catch. Tested and confirmed that patch safely removes the duplicate code and theres no unwanted side-effect. Marking with Merge on pass