Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for dev/core#686: Make "amount statistics" columns optional #13507

Merged
merged 1 commit into from
Jan 31, 2019

Conversation

twomice
Copy link
Contributor

@twomice twomice commented Jan 25, 2019

Overview

Currently the column "Amount Statistics" is required on the Membership Summary report. Some people report that users find these columns confusing. This PR aims to make them optional, but enabled by default.

Before

"Amount Statistics" is required.
stats_required

After

"Amount Statistics" is optional.
stats_optional

Technical Details

Seems to "just work". Wonder why this was required in the first place. Am I inadvertently breaking anything here?

Comments

[none]

@civibot
Copy link

civibot bot commented Jan 25, 2019

(Standard links)

@civibot civibot bot added the master label Jan 25, 2019
@yashodha
Copy link
Contributor

@twomice
looks good and makes sense.

@colemanw
Copy link
Member

I don't see any downside to this.

@colemanw colemanw merged commit 5523128 into civicrm:master Jan 31, 2019
@twomice
Copy link
Contributor Author

twomice commented Jan 31, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants