Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Survey form - use number widget for number fields #13503

Merged
merged 1 commit into from
Jan 24, 2019

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Jan 24, 2019

Overview

Part of an ongoing/sporadic effort to update fields with html5 type info when appropriate.

Before

"New Survey" form treats "Maximum reserved at one time," "Total reserved per interviewer" & "Release Frequency" as plain-text input.

After

"New Survey" form treats "Maximum reserved at one time," "Total reserved per interviewer" & "Release Frequency" as number input for improved accessibility.

@civibot
Copy link

civibot bot commented Jan 24, 2019

(Standard links)

@JoeMurray
Copy link
Contributor

Test failure unrelated to surveys. Code looks good. Widgets work on campaign create and edit.

@JoeMurray JoeMurray merged commit c1eb426 into civicrm:master Jan 24, 2019
@colemanw colemanw deleted the numberWidget branch January 24, 2019 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants