Fix shortcode button when popup setting is disabled

[colemanw]

Overview

Allows the shortcode popup to work normally even when ajax popups are disabled in CiviCRM settings.

Depends on civicrm/civicrm-wordpress#145

Before

When jax popups are disabled in CiviCRM settings the WP shortcode button was broken.

After

Now works with or without the setting.

Comments

This PR isn't nearly as big as it looks. It's mostly whitespace changes.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[colemanw]

@civicrm-builder retest this please

[colemanw]

@civicrm-builder retest this please

[colemanw]

@civicrm-builder retest this please

[colemanw]

@civicrm-builder retest this please

[kcristiano]

• (r-explain)Pass
• (r-test)Pass
• (r-code) Pass
• (r-doc) Pass
• (r-maint) Undecided
• (r-run) Applied both PRs to master. Turned off pop ups as described. Shortcode button works properly
• (r-user) Pass
• (r-tech) Pass

[colemanw]

Thanks for the review @kcristiano. I think the maint issue is a bit moot since shortcodes are on their way out.

[kcristiano]

@colemanw I do expect that shortcodes will be around for quite some time. I think many WP agencies and larger sites are treating version 4.9.x as LTS. Considering Security patches are being applied back to Version 3.7.x (released 2013) we have some time.