Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#677 EntityRef filters fixes #13493

Merged
merged 2 commits into from
Jan 25, 2019
Merged

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Jan 22, 2019

Overview

Fixes two bugs in EntityRef widget filters (e.g. the "Refine Search..." area when entering a contact on a form).

Before

  1. Contact Type filter was broken for contactRef fields that already had a contact type specified (e.g. Current Employer field is set to contact type Organization)
  2. Filters specific to Individuals were showing even when a different contact type was specified (e.g. Current Employer field allowed to filter by Deceased and Gender - which are irrelevant to Organizations).

After

  1. Fixed.
  2. Fixed.

See https://lab.civicrm.org/dev/core/issues/677

@civibot civibot bot added the master label Jan 22, 2019
@civibot
Copy link

civibot bot commented Jan 22, 2019

(Standard links)

@colemanw colemanw changed the title EntityRef filters fixes dev/core#677 EntityRef filters fixes Jan 22, 2019
@colemanw
Copy link
Member Author

@civicrm-builder retest this please

@pradpnayak
Copy link
Contributor

Thanks @colemanw for the fix, I did QA on current state of code, the gender id and deceased are now only available on individual search

Before:

before

After:

after

@colemanw
Copy link
Member Author

Merging based on review.

@colemanw colemanw merged commit e3cbde6 into civicrm:master Jan 25, 2019
@colemanw colemanw deleted the entityRefFilters branch January 30, 2020 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants