dev/core#561 - Convert grant task form to datepicker #13485
Conversation
|
(Standard links)
|
|
@civicrm-builder retest this please |
|
@JoeMurray could you spare 5 minutes to review this? Can just do it on the test site online. |
|
@civicrm-builder retest this please |
|
Sorry I missed this earlier. Code looks good on review. Will test in a moment. |
| </tr> | ||
| {/foreach} | ||
| </table> | ||
| <p>{ts 1=$totalSelectedGrants}Number of selected grants: %1{/ts}</p> | ||
| <div class="crm-submit-buttons">{include file="CRM/common/formButtons.tpl" location="bottom"}</div> | ||
| </div><!-- /.crm-form-block --> | ||
| </div> |
There was a problem hiding this comment.
Just for my information, what was this comment that has been removed originally for? Is it a cut and paste remnant?
There was a problem hiding this comment.
For whatever reason, the original .tpl code was extremely messy, lines were indented completely at random and it was very hard to tell what opening tags corresponded to what closing tags. So I guess rather than indent properly someone decided to put a comment whenever closing a tag about what opening tag it corresponded to?
There was a problem hiding this comment.
Since Grants is a newer component I assume this tpl was created by copy-pasting some other tpl and thus inherited messy whitespace and useless closing comments.
colemanw
force-pushed
the
grantTaskDate
branch
from
049a4bf to
54d7f37
Compare
|
Adding merge-on-pass based on Joe's review. |
Summary
Changes one form element to datepicker widget. This is a really simple change as the field doesn't require any preprocesing (the form element never has a default value) or postprocessing (the value is simply passed through
strtotimewhich works with either format).Steps to test