Add main nav icon for CiviCRM (Backdrop) #13481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(since Backdrop core now has main nav icons)
|
(Standard links)
|
laryn
changed the title
|
This looks fine. |
|
@colemanw I will give that a shot, sure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(since Backdrop core now has main nav icons)
Overview
Backdrop core added nav icons in 1.12 and added a class (based on the path) to all main nav items –
civicrmhas a class but no icon.Before
After
Technical Details
Added styling based on backdrop/backdrop-issues#1841 using an existing icon image that is used in the CiviCRM admin menu.
Comments
I might have used a white logo to match the other admin icons but that may go against brand usage policy and would have required an additional file to be added.