setLocale: precaution for when setLocale is called on an unilingual site #13465
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This is a small tweak for a specific use-case:
CRM_Core_I18n::setLocale()
, but not checking if the site is in multi-lingual (ex: cdntaxreceipts).but it might also cover the use-case where a site uses the multi-gettext language option, but not multi-lingual database (ex: #13240).
Before
Calling
setLocale()
on a non-multilingual DB would cause subsequent SQL queries to fail, because thedbLocale
suffix gets set, but the sql views do not exist.After
DB queries do not fail.