Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REF Remove undefined variable when creating note #13457

Merged
merged 1 commit into from
Jan 20, 2019
Merged

REF Remove undefined variable when creating note #13457

merged 1 commit into from
Jan 20, 2019

Conversation

mattwire
Copy link
Contributor

Overview

Just remove an if statement that can never be true

Before

The variable $note can never be defined when we get to the else so the code will never run.

After

Remove the code that will never run.

Technical Details

Comments

@civibot
Copy link

civibot bot commented Jan 15, 2019

(Standard links)

@civibot civibot bot added the master label Jan 15, 2019
@seamuslee001 seamuslee001 mentioned this pull request Jan 16, 2019
Merged
@seamuslee001
Copy link
Contributor

Jenkins re test this please

@colemanw colemanw merged commit 4e6e5cc into civicrm:master Jan 20, 2019
@colemanw
Copy link
Member

Oh I see now.
FYI this commit accidentally made it into another of your PRs.

@colemanw colemanw mentioned this pull request Jan 20, 2019
Merged
@mattwire mattwire deleted the contact_note branch March 1, 2019 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mattwire @seamuslee001 @colemanw