Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate unused function #13452

Merged
merged 1 commit into from
Jan 17, 2019
Merged

Deprecate unused function #13452

merged 1 commit into from
Jan 17, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Mark a function deprecated

Before

No indication function is unused

After

Function gives deprecation warning

Technical Details

I grepped & couldn't see any evidence this is in use.

Comments

@civibot
Copy link

civibot bot commented Jan 15, 2019

(Standard links)

@civibot civibot bot added the master label Jan 15, 2019
@eileenmcnaughton
Copy link
Contributor Author

test this please

1 similar comment
@eileenmcnaughton
Copy link
Contributor Author

test this please

@pradpnayak
Copy link
Contributor

pradpnayak commented Jan 17, 2019 •
edited
Loading

Change looks straight forward. Good to merge!

@seamuslee001 seamuslee001 merged commit c6739ed into civicrm:master Jan 17, 2019
@seamuslee001
Copy link
Contributor

done thanks @pradpnayak and @eileenmcnaughton

@seamuslee001 seamuslee001 deleted the depre branch January 17, 2019 01:13
@eileenmcnaughton
Copy link
Contributor Author

thanks @seamuslee001 @pradpnayak

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eileenmcnaughton @pradpnayak @seamuslee001