Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix undefined index warning #13433

Merged
merged 1 commit into from
Jan 11, 2019
Merged

Fix undefined index warning #13433

merged 1 commit into from
Jan 11, 2019

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Jan 10, 2019 •
edited
Loading

Overview

Fixes adding an activity with no subject to the recent items list.

Before

When viewing an activity with no subject, the recent items entry appears blank, and an undefined index warning appears.

After

The recent items entry says "(no subject)" which is consistent with the rest of the UI. No warning.

@civibot civibot bot added the master label Jan 10, 2019
@civibot
Copy link

civibot bot commented Jan 10, 2019

(Standard links)

@yashodha
Copy link
Contributor

@colemanw
looks good, merging this

@yashodha yashodha merged commit 51e0fba into civicrm:master Jan 11, 2019
@colemanw colemanw deleted the actSub branch January 11, 2019 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@colemanw @yashodha