Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default for domain_id for report_instance. #13426

Merged

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Uses current domain as a sensible default for ReportInstance.create rather than it being a required field

Before

ReportInstance.create with no domain_id will give a mandatory field error

After

ReportInstance.create with no domain_id will succeed, assuming current domain

Technical Details

This is consistent with other api like Job, MembershipType, PaymentProcessor

Comments

This is consistent with other api like Job, MembershipType, PaymentProcessor
@civibot
Copy link

civibot bot commented Jan 9, 2019

(Standard links)

@civibot civibot bot added the master label Jan 9, 2019
@eileenmcnaughton
Copy link
Contributor Author

test this please

@seamuslee001
Copy link
Contributor

This looks fine to me makes sense tests have passed. Merging

@seamuslee001 seamuslee001 merged commit 93ab3f3 into civicrm:master Jan 9, 2019
@eileenmcnaughton eileenmcnaughton deleted the report_instance_domain branch January 10, 2019 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants