Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/drupal#43 Update composer requirement on PSR Log and civicrm-cxn-… #13424

Merged
merged 1 commit into from
Jan 9, 2019

Conversation

seamuslee001
Copy link
Contributor

…rpc to fix compatability issue with psr/log from Drupal8

Overview

This updates the civicrm-cxn-rpc and psr/log requirements so that the version of psr/log will be 1.1 installed. the cxn has just had a new release with the updated log requirement done which is the only change between the releases. This fixes a compatibility issue with Drupal 8

Before

Compatibility issue with Drupal 8 over version of psr/log to install

After

No issue

ping @totten @eileenmcnaughton @MegaphoneJon @mlutfy

@civibot
Copy link

civibot bot commented Jan 8, 2019

(Standard links)

@civibot civibot bot added the master label Jan 8, 2019
@mlutfy
Copy link
Member

mlutfy commented Jan 8, 2019

Seems good to me.

@mlutfy mlutfy changed the title (dev/mail#34) Update composer requirement on PSR Log and civicrm-cxn-… dev/mail#34 Update composer requirement on PSR Log and civicrm-cxn-… Jan 8, 2019
@mlutfy
Copy link
Member

mlutfy commented Jan 8, 2019

@seamuslee001 dev/mail#34 seems like the wrong ref? Is this dev/drupal#43 ?

@seamuslee001
Copy link
Contributor Author

@bgm yes woops

@seamuslee001 seamuslee001 changed the title dev/mail#34 Update composer requirement on PSR Log and civicrm-cxn-… dev/mail#43 Update composer requirement on PSR Log and civicrm-cxn-… Jan 8, 2019
@mlutfy mlutfy changed the title dev/mail#43 Update composer requirement on PSR Log and civicrm-cxn-… dev/drupal#43 Update composer requirement on PSR Log and civicrm-cxn-… Jan 8, 2019
@mlutfy
Copy link
Member

mlutfy commented Jan 8, 2019

Mind also amending your commit description?

…c to fix compatability issue with psr/log from Drupal8
@seamuslee001
Copy link
Contributor Author

done @mlutfy

@seamuslee001
Copy link
Contributor Author

@mlutfy would you consider it as "merge on pass"

@mlutfy mlutfy merged commit 6ddd029 into civicrm:master Jan 9, 2019
@seamuslee001 seamuslee001 deleted the dev-drupal-43 branch January 9, 2019 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants