Membership custom fields sometimes don't display #13411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
mattwire
commented
Jan 7, 2019
| @@ -581,7 +581,7 @@ public function buildQuickForm() { | |||
| ); | |||
|
|
|||
| if (!empty($this->_recurPaymentProcessors)) { | |||
| $memTypeJs['onChange'] = "" . $memTypeJs['onChange'] . "buildAutoRenew(this.value, null, '{$this->_mode}');"; | |||
| $memTypeJs['onChange'] = "" . $memTypeJs['onChange'] . " buildAutoRenew(this.value, null, '{$this->_mode}');"; | |||
There was a problem hiding this comment.
Without the space I'm getting a console error when editing a membership that 'buildAutoRenew' is not defined.
|
Yes, initial testing suggests this has fixed it - thank you! |
|
Code looks correct. Merging based on user testing and tests passing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
There is a very irritating issue to do with displaying custom fields in Memberships, where some custom field sets don't appear -- sometimes! So if you have Set 1, Set 2, and Set 3, you can edit a membership and sometimes Set 1 will be there and sometimes it won't.
I've just replicated this on the staging site. Here's how to do it:
On a Wordpress or Drupal demo site, create three Custom Data sets. These should apply to Memberships. The first should apply to the 'Student' membership type, and the second and third should be for 'All' membership types. Let's say they're called Set 1, Set 2, and Set 3.
Create a single field in each one.
Create a Student membership on someone's record.
Click edit on the membership, from the memberships tab. Do this repeatedly, then close the pop-up. Sometimes Set 1 will appear and sometimes it won't. (actually, I'm pretty sure it appears then disappears)
Before
Custom data is built twice, first without a customdata subtype and then with a customdata subtype. Depending on the speed of page load / order of execution customdata specific to a subtype may or may not be displayed.
After
Custom data is built once on the form. Either with a subtype or without a subtype as required.
Technical Details
This code was extracted relatively recently as part of efforts to improve custom data handling on forms. No changes were made at the time but the same code pattern appears in multiple places, sometimes with each CRM.buildCustomData wrapped in an if statement, sometimes no if statement for the first one - meaning it will run twice if the form has a subtype (eg membership_type, case_type).
Comments
@bhahumanists Are you able to confirm this fixes the issue?