Donot allow to enter more than max length of the field #13403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
@pradpnayak the way we have been dealing with these is switching to using the addField method - in general using addField allows us to centralise our methodology & metadata - are you able to give that a go? You might need to add a couple of declares |
pradpnayak
force-pushed
the
FieldLength
branch
from
614f889
to
2b59da4
Compare
|
@eileenmcnaughton I have updated the PR to use addField method. Can you please review? |
|
I gave this a spin & it looks good to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
https://lab.civicrm.org/dev/core/issues/639
Before
The subject field allowed unlimited chars to input
After
Restricted to 255 chars only