Add routine for updating smartgroups, currently handling datepicker conversion

[eileenmcnaughton]

Overview

Convert fields from smart groups using grant date fields to reflect new datepicker format

Before

As of #13211 the fields are converted in the search but pre-existing smart groups still use the old format for these dates

After

On upgrade the groups are updated to the new format

Technical Details

Merge in conjuction with #13211

This ties in with the larger effort in https://lab.civicrm.org/dev/core/issues/561 to remove jcalendar. I started down the path of on-form conversions but decided in the long run it would be cleaner to upgrade the groups - this approach could probably safely be applied to some already updated ones like lybunt custom search in order to remove cruft.

I think the upgrade part could be iterated on for more improvements. Campaign Search seems like the obvious next form for daterange updates

Comments

@seamuslee001 @monishdeb @mattwire

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[colemanw]

@eileenmcnaughton do we need to convert all advance search components to datepicker within a single upgrade cycle for best results? If so, this is the perfect time of month to start on that project.

[eileenmcnaughton]

@colemanw we don't need to do them all at once but when we convert the fields we do need to do this - I'm not seeing this as something to do all in one release both from a volume and a risk POV

[colemanw]

This is excellent work @eileenmcnaughton. I have one nitpick about the design. The way you've done it here, the addTask function passes a version number to updateSmartGroups which then relies on the data in getSmartGroupConversions to figure out what to do. That's a bit hard to grok and seems like it might cause trouble for future devs trying to figure out and extend what you've done. Since the addTask function can accept a variable number of arguments, I'd suggest passing in whatever's needed directly, e.g.

    $this->addTask('Update grant smart groups for datepicker', 'updateSmartGroups', $rev, [
      'function' => 'datepickerConversion',
      'fields' => [
        'grant_application_received_date',
        'grant_decision_date',
        'grant_money_transfer_date',
        'grant_due_date'
      ]
    ]);

[eileenmcnaughton]

@colemanw yeah I guess so - I just thought it would create one array where we could kinda track what had been done when