dev/mail#32 - Making mailing test email non-case-sensitive

[martinh-pw]

As per https://lab.civicrm.org/dev/mail/issues/32

Added call to strtolower() when processing the user-provided test email addresses for a mailing. Updated MailingTest.php:testMailerSendTest_email to use a mixed-case email.

[civicrm-builder]

Can one of the admins verify this patch?

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[colemanw]

@civicrm-builder add to whitelist

[eileenmcnaughton]

test fail is unrelated

[eileenmcnaughton]

@martinh-pw this doesn't cover ALL scenarios - ie. if the email in the database is not lower case then you could get a new email added still. However, I am going to merge this & let you decide whether you want to address that as a follow up because

1. lower case for emails is pretty much the standard & it seems OK to priorise that as the best-handled scenario
2. this is better than the status quo IMHO
3. there is unit test coverage on the change you made.

Congrats on your first merged PR I think?

[tschuettler]

@eileenmcnaughton Are there actually instances where the email in the database may end up not beeing lower case? I was under the impression that it is always stored as lower case.

[martinh-pw]

Thanks @eileenmcnaughton :)

Yes, same as @tschuettler my understanding was that emails in the db are already expected to be lowercase. Regardless, I've added some further tweaks to account for that possibility:

#13401

[eileenmcnaughton]

@tschuettler @martinh-pw don't we just save them as entered?

[martinh-pw]

I know that if you enter an email address on the Add Contact page, or inline on the Contact page, civi will convert it to lower. I don't know if that happens in all cases, but it seems likely it would happen as a general rule. That's not exactly a definitive answer though!

[tschuettler]

@eileenmcnaughton I don't think so. At least I could not find any way to create a non-lowercase email (tested with CSVImport, apiv3, apiv4, GUI edit). There is none in our datebase aswell.