Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Colombian provinces #13391

Closed
wants to merge 1 commit into from
Closed

Conversation

sluc23
Copy link
Contributor

@sluc23 sluc23 commented Jan 3, 2019

Overview

Fix 2 Colombian provinces.
Ref: https://es.wikipedia.org/wiki/Departamentos_de_Colombia

Before

province name Caldea must be Caldas
province Huila is missing

After

Caldas (id: 2151)
Huila (id: 10365)

Comments

I'm not sure if civicrm_generated.mysql is the only file to fix this

@civibot
Copy link

civibot bot commented Jan 3, 2019

(Standard links)

@civibot civibot bot added the master label Jan 3, 2019
@sluc23
Copy link
Contributor Author

sluc23 commented Jan 3, 2019

This PR doesn't fix existing installations, just for new ones.
Not sure how to deal with existing ones, as in our case we fixed this manually in the DB

@MegaphoneJon
Copy link
Contributor

MegaphoneJon commented Jan 3, 2019

It's pretty easy @sluc23! Here's a good example: #12168. The only caveat is that the INSERT statement should be INSERT IGNORE to avoid giving an error to sites that have already fixed this. In the example I linked you, it was fixed in a separate commit.

@seamuslee001
Copy link
Contributor

it should also be noted that that file that you have edited is normally generated via running ./bin/setup.sh -Dg i think so what you need to do is edit the template file as per 12168 and then run that script and it will auto generate the generated data file and then you will want to edit the 5.11.alpha1 upgrade file

@JoeMurray
Copy link
Contributor

Closing since you need to update a different file, not the generated one. Please resubmit.

@JoeMurray JoeMurray closed this Jan 4, 2019
@sluc23 sluc23 deleted the dev-ColombiaStates branch January 4, 2019 17:00
@sluc23
Copy link
Contributor Author

sluc23 commented Jan 4, 2019

tried to run ./bin/setup.sh using docker buildkit, but having some issues. I'll try doing other way. tx for the tips, I'll make another PR when everything is ready

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants