(dev/core#491) Campaign Cleanup in Activity, Member Contribution Deta… #13382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
Shouldn't we have clean up of each file as a separate PR? It reduces the chances of bugs while doing cleanup IMO. |
|
@yashodha I've been very happy that you have been doing separate files as it has made it easier for me to review them - you have your head pretty heavily in this code already so you might be happy to do 3 in one PR? |
…il and Member Lapse reports
seamuslee001
force-pushed
the
report_cleanup
branch
from
6b893b7
to
254ca42
Compare
|
@seamuslee001 looks good, merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…il and Member Lapse reports
Overview
This continues the standardisation of Reports in regards to adding of campaign fields into the reports cleaning up 3 more reports
ping @eileenmcnaughton @yashodha