Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct syntax "IS NOT NULL" to get pledge payment count #13374

Merged
merged 1 commit into from
May 26, 2019

Conversation

sunilpawar
Copy link
Contributor

Overview

Get Count for Pledge Payment.
Once Pledge have payment (status is In-Progress), we can not update the pledge amount and number of instalment.
but if Pledge have payment and some payment status is overdue then Pledge status change to 'overdue' and this allow to update pledge amount and number of instalment.

Before

API return 0 count

After

API return actual payment count. Edit screen screen get freezed.

Technical Details

correct syntax for is not null

@eileenmcnaughton
Copy link
Contributor

Change looks correct - should be easy to write a test for

@civibot
Copy link

civibot bot commented Dec 31, 2018

(Standard links)

@civibot civibot bot added the master label Dec 31, 2018
@prondubuisi
Copy link
Contributor

Hello @sunilpawar @eileenmcnaughton can I please get a little background story on this issue?
what does the PR fix?

Copy link
Contributor

@JoeMurray JoeMurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To test, create a pledge. Do a get count on contributions against the pledge. Apparently it should fail prior to this PR and succeed after this PR.

@sunilpawar I don't see relevance of much of the description to the code change. Are those areas where the api bug manifests in the UI?

@seamuslee001
Copy link
Contributor

I'm going to merge this as its correct and we have a test in #14350

@seamuslee001 seamuslee001 merged commit 085d8bc into civicrm:master May 26, 2019
@eileenmcnaughton
Copy link
Contributor

Thanks @seamuslee001

@sunilpawar can you add a test next time please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants