NFC: Improved documentation of crmPageTitle directive. #13337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documented assumption that AngularJS base page be named "CiviCRM."
|
(Standard links)
|
|
Basically the timeout is used throughout our angular code to prevent race conditions. |
universalhandle
added a commit
to ginkgostreet/org.chorusamerica.orgdash
that referenced
this pull request
Jan 4, 2019
organization contact information available to all states. - Added error page for invalid contact IDs. - Updated page title to include the name of the organization contact (note: for the crmPageTitle directive to work, the AngularJS base page cannot have a custom title -- it must be named "CiviCRM"; see civicrm/civicrm-core#13337). - Updated file name for DashCtrl to match conventions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Documented assumption that AngularJS base page be named "CiviCRM".
Comments
Is there interest in removing this requirement? It seems like the values for
pageTitleanddocumentTitlecould be derived in thelinkfunction and assigned to local variables instead of being hardcoded to global variables. My gut, however, tells me that perhaps the code was written this way for a reason (i.e., mysterious bugs).It is a little unusual that
updateis wrapped in a$timeout. If I had to guess, it's to keep the$watchfunction from triggering unnecessarily, sinceupdatechanges both parts of the watched expression. Does this effectively make the change atomic, rather than having the$watchfunction fire once whenpageTitleis updated and again whendocumentTitleis updated?