Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#603 not set default value yes/no for active relationship filters #13296

Merged
merged 1 commit into from
Dec 18, 2018

Conversation

mathavanveda
Copy link
Contributor

Overview

On Case Summary report,
When run report without any changes are any filters then you would this warning message
warning message

Then unselect the Staff Member Column and Relationship column on Column tab and run the report would end up with DB Error unknown column.
unselectrelationshipfields

Before

It just returning DB error with unknown column
db error

I think is because of filter "Active Relationship" is set to "Yes" by default.
filter

After

I have amended the boolean option to unset the default value.
default

afterthefix

@civicrm-builder
Copy link

Can one of the admins verify this patch?

@civibot
Copy link

civibot bot commented Dec 17, 2018

(Standard links)

@civibot civibot bot added the master label Dec 17, 2018
@yashodha
Copy link
Contributor

looks good, minor change that can be merged once tests pass

@yashodha
Copy link
Contributor

test this please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants