Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(NFC) Add 'schema' to \Civi\Token\TokenProcessor() #13286

Merged
merged 1 commit into from
Jan 3, 2019

Conversation

aydun
Copy link
Contributor

@aydun aydun commented Dec 14, 2018

Overview

Extracted from #13174 #12012 Small change to \Civi\Token\TokenProcessor() to add a schema setting - as discussed with / proposed by @totten NFC currently, but allows

@civibot
Copy link

civibot bot commented Dec 14, 2018

(Standard links)

@civibot civibot bot added the master label Dec 14, 2018
@seamuslee001
Copy link
Contributor

Jenkins re test this please

1 similar comment
@seamuslee001
Copy link
Contributor

Jenkins re test this please

@aydun
Copy link
Contributor Author

aydun commented Dec 17, 2018

test this please

@mattwire
Copy link
Contributor

mattwire commented Jan 3, 2019

I've reviewed this, it's adding code to support new functionality so does not impact existing functionality. The code change has been discussed with @totten so I'm happy with the principle. @seamuslee001 @eileenmcnaughton Could one of you merge?

@seamuslee001
Copy link
Contributor

Merging based on @mattwire 's review

@seamuslee001 seamuslee001 merged commit 88db78b into civicrm:master Jan 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants