Prevent \Civi\Token\TokenCompatSubscriber::evaluate() erroring when no contactId is given. #13284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
This is compatibility code. I'm not sure why we'd end up with no contact Id but can see why it would fail if we did. The result of a missing contact Id would be a failure to process further tokens which is undesirable. @seamuslee001 @eileenmcnaughton Could one of you merge? |
|
Merging as per @mattwire 's review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Extracted from #13174 and #12012 Handle the situation when \Civi\Token\TokenCompatSubscriber::evaluate() is called with no contactId specified in the row context. Should not error.