Unable to mark price set field as inactive

[vinuvarshith]

Overview

When you edit a price field (via CiviCRM/Events/Manage Price Sets/View and Edit Price Fields/Edit Price Field) and uncheck the "Active?" checkbox and click save, the change is not saved and the field remains active. This fail only for Text/Numeric. Checking the "Active?" (when the field is disabled) it does work and the field is enabled.

After

We can set a price field to both 'enabled' and 'inactive' without issues

Technical Details

In CRM/Price/Form/Field.php postprocess, when html_type is 'Text', the params are modified as per the option group and option value. Here 'is_active' param is always set to 1 and so it cannot be set to inactive.
This PR fixes it by using 'is_active' from params instead of always using 1.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

So that line was added by @alifrumin in 2017 in 2db35bf - my take on it is that the line could & should be removed & may have been added by accident.

I see it being set correctly higher up

    $params['is_active'] = CRM_Utils_Array::value('is_active', $params, FALSE);
``

@alifrumin any thoughts

[alifrumin]

@eileenmcnaughton I agree that line should not be hardcoded to equal 1. I am not sure how that snuck in there.

I am happy to test this when its ready.

[eileenmcnaughton]

@vinuvarshith per above can you edit to remove that line altogether?

[vinuvarshith]

@eileenmcnaughton @alifrumin
Thanks for confirming. I have updated by removing that line.

[alifrumin]

I tested this on the Jenkins build based off of @vinuvarshith solid documentation at the top and it is ready to merge from my perspective.

[eileenmcnaughton]

thanks @alifrumin @vinuvarshith !