(RFC) Fix Locale Test by re-setting the locale used to en_US and by resetting the I18n singleton #13246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
seamuslee001
changed the title
Ensure that CRM_Core_I18n singleton is cleared as well
seamuslee001
force-pushed
the
locale_test_fix
branch
from
7b331bf
to
9d65201
Compare
seamuslee001
changed the title
|
Removed WIP and changed to RFC given the code changes now needed, I think this will fix it |
seamuslee001
changed the title
mlutfy
approved these changes
Dec 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This fixes an issue in unit tests where subsequent tests remain in French and not are in English because the locale has not been reset
Before
Subesquent tests would remain in french as per https://test.civicrm.org/job/CiviCRM-Core-Matrix/BKPROF=min,CIVIVER=master,label=bknix-tmp/5951/#showFailuresLink
After
Tests Fixed because locale is reset