Typos, simplify if statement #13233
Merged
Typos, simplify if statement #13233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
totten
reviewed
Dec 5, 2018
|
|
||
| // required only if paid event | ||
| if ($this->_values['event']['is_monetary'] && !($this->_allowWaitlist || $this->_requireApproval)) { | ||
| elseif ($this->_values['event']['is_monetary']) { |
There was a problem hiding this comment.
Agree this looks equivalent. 👍
- The removed conditional is the logical opposite of the previous
if ($this->_allowWaitlist || $this->_requireApproval) { - In the body of the
if { ... }, there doesn't appear to be anything which could change the value of$this->_allowWaitlistor$this->_requireApproval.
|
Looks good - mostly NFC, with a small bit of REF that checks out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Just fix some typos and simplify an if statement (change to if/elseif as the conditions are exclusive)
Before
Typos, slightly more complicated code.
After
Less typos, slightly less complicated code.