dev/core#407 Fix mis-saving of price field values under localisation.

[eileenmcnaughton]

Overview

Fixes a localisation bug whereby membership config on contribution pages results in it saving (or trying) to save the wrong amount for comma-decimal sites

Before

Set up a site as comma for decimal place & . for thousand separator.
-create a new membership type

• add this type to a 'non-price set' membership page
• error on save
  

After

Saves correctly

Technical Details

The amount is being inappropriately cleaned in the BAO layer - these values should always be clean by the time they get here

Comments

@mattwire

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

(CiviCRM Review Template WORD-1.2)

• General standards
  • (r-explain) Pass
  • (r-user) Pass reduces a fatal error
  • (r-doc) Pass
  • (r-run) Pass I tested this and was able to replicate the fatal error, applied the patch and confirmed that it worked after. I also confirmed that the correct amount was saved into the database.
• Developer standards
  • (r-tech) Pass
  • (r-code) Pass
  • (r-maint) Pass
  • (r-test) Pass