dev/core#529 open search panes when when reviewing smart groups if they have stuff selected #13217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ey have stuff selected To replicate - create a smart group based on an activity. Go into the group & go to edit smart group criteria - pane is not open and risks being ignored. I think this was just oversight in the tpl & the openedPanes should override any defaults for the pane
|
(Standard links)
|
|
@monishdeb @seamuslee001 could one of you review this - pretty trivial & a) fixes a bug & b) helps to look at other current search form changes |
|
test this please |
|
@eileenmcnaughton Thanks. I did a quick test and it looks good, I'll review https://lab.civicrm.org/dev/core/issues/529 to ensure we test the know problems and report back. |
|
Jenkins re test this please |
|
Adding merge on pass based on @kcristiano 's review |
|
Jenkins re test this please |
|
Merging as per the tag |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes a scenario where some search criteria can be lost when editing smart groups
Before
To replicate - create a smart group based on an activity. Go into the group & go to edit smart group criteria - pane
is not open and risks being ignored.
After
Accordian pane is opened on load if there are activity criteria. Criteria are respected
Technical Details
This is a generic fix for https://lab.civicrm.org/dev/core/issues/529 but I don't know if there are variants of that that are NOT fixed by this
I think this was just oversight in the tpl & the openedPanes should override any defaults for the pane
Comments
@kcristiano this was one you put on our radar