Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#561 Convert Activity Custom Search from jcalendar to datepic… #13203

Merged

Conversation

seamuslee001
Copy link
Contributor

…ker and fix indenting in tpl file

Overview

This Converts the Activity Custom Search from using deprecated jcalendar fields to datepicker fields

Before

Used deprecated jcalendar fields

After

Uses datepicker fields

ping @eileenmcnaughton @mattwire

@civibot
Copy link

civibot bot commented Dec 1, 2018

(Standard links)

@civibot civibot bot added the master label Dec 1, 2018
@eileenmcnaughton
Copy link
Contributor

@seamuslee001 so with all these searches we have the issue of pre-existing smart groups - however, I looked at this search and I can see no logic in it's existence since it just partially duplicates normal activity search functionality - so I can't imagine anyone having smart groups based on it.

I'm gonna add a follow up in gitlab on how we can move these reports out of core....

@eileenmcnaughton eileenmcnaughton merged commit 2227358 into civicrm:master Dec 2, 2018
@eileenmcnaughton eileenmcnaughton deleted the activity_search_core_561 branch December 2, 2018 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants