dev/core#563: Duplicate Case manager role fix

[monishdeb]

Overview

Steps to replicate:

1. Create case
2. Go to 'Manage case' and change case manager to someone else
3. Change case manager back to original contact: error - duplicate relationship
4. From the contact's relationship tab, enable a relationship
   -- note that the end date is preserved, which may mean that the newly re-enabled relationship is still considered inactive
   -- note that in the manage case roles panel the newly re-enabled relationship is not listed as the case manager
5. From the manage case roles panel, add a new role with the same case manager type, to one of the existing contacts: error, duplicate relationship
   -- so if you change the case manager, there's currently no way to go back and set the original contact as case manager again

Before

After

Comments

ping @colemanw @lcdservices

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[lcdservices]

we've tested this PR and are already using in production.

[jitendrapurohit]

Tested and confirmed that the PR fixes the issue of role assignment as mentioned in the description. +1 to get this merged into core @eileenmcnaughton

[monishdeb]

Thanks @jitendrapurohit @lcdservices for your feedback.

@eileenmcnaughton or @seamuslee001 can you please merge this PR?

[seamuslee001]

Merging as per Brian's and Jitendra's reviews.

[monishdeb]

Thanks @seamuslee001