Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(dev/core#559) Declare crmUi's dependency on ui.utils. #13180

Merged
merged 1 commit into from
Nov 30, 2018

Conversation

universalhandle
Copy link
Contributor

Overview

This pull request declares crmUi's dependency on ui.utils.

Before

crmUiTabSet directive doesn't work in apps on a custom AngularJS base page unless developer figures out and includes its dependencies.

After

Developer's custom module declares crmUi as a dependency and can use the crmUiTabSet directive.

Comments

See issue tracker for more information.

@civibot
Copy link

civibot bot commented Nov 29, 2018

(Standard links)

@civibot civibot bot added the master label Nov 29, 2018
@colemanw
Copy link
Member

Seems reasonable.

@totten
Copy link
Member

totten commented Nov 30, 2018

Agree.

Reported test failures appear to be unrelated false-negatives.

@totten totten merged commit d9f3e10 into civicrm:master Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants