Fix links for tabs on manage event #13172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
This will need to go against the RC if we are happy with it |
|
@jitendrapurohit what do you think? @mattwire yes - can you transfer it to the rc? |
jitendrapurohit
approved these changes
Nov 30, 2018
There was a problem hiding this comment.
Tested on the manage event page - works fine 👍 Thanks @mattwire
|
Ok this needs to be against 5.8 - I'm a little on the fence about whether it is the best fix - but it resolves the issue in the rc |
… tab but need selectedChild to be specified or the default tab is loaded
mattwire
force-pushed
the
events_tabheader_fixselectedchild
branch
from
155ee3e to
e6ac9af
Compare
|
@seamuslee001 Rebased onto 5.8 |
|
Adding merge on pass based on Jitendra's Review |
|
Jenkins re test this please |
|
Merging as per the tag and Jitendra's review thanks @mattwire |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
See #12747 (comment)
Before
Links to manage event tabs broken following work on "selected tab" functionality.
After
Links to manage event tabs working.
Technical Details
Events are "unique" in that each tab has it's own full URL, whereas all other "tabheader" pages in CiviCRM use a single link and a "selectedChild" parameter to specify which tab to load.
Comments
@jitendrapurohit Please review.