Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set currency template variable from contribution pages #13157

Merged
merged 1 commit into from
Nov 28, 2018

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Assign $currency variable to the template for contribution pages more consistently

Before

Under some circumstances the smarty var currencyID is not populated

After

variable is more consistenty populated

Technical Details

When we load the PaymentForm the currency is set there and assigned to the template.

However, if the form doesn't load by default (ie because there is no payment processor selected by
default) the currency variable is not assigned to the template.

When the payment form is loaded by
var dataUrl = '{crmURL p='civicrm/payment/form' h=0 q=formName=

Comments

@civibot
Copy link

civibot bot commented Nov 26, 2018

(Standard links)

@civibot civibot bot added the master label Nov 26, 2018
When we load the PaymentForm the currency is set there and assigned to the template.

However, if the form doesn't load by default (ie because there is no payment processor selected by
default) the currency variable is not assigned to the template.

When the payment form is loaded by
      var dataUrl = '{crmURL p='civicrm/payment/form' h=0 q=formName=
@mattwire
Copy link
Contributor

Confirmed that without this PR currency is not always assigned to the form on a contribution page. With this PR it is! Ok to merge.

@eileenmcnaughton eileenmcnaughton merged commit 68dc5ae into civicrm:master Nov 28, 2018
@eileenmcnaughton eileenmcnaughton deleted the currency branch November 28, 2018 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants