Fix check for financial acls to look for setting rather than sub-key of non-standard civicontribute_settings' setting

[eileenmcnaughton]

Overview

Fixes an intra-rc regression where setting for financial acl was not being picked up

Before

Newly enabled financial acls ignored

After

Acls picked up

Technical Details

Some true awfulness was introduced in contribution settings a while ago. Some settings were declared as settings and settable via the api - but only worked when saved to 'the wrong place' via the preferences form munging them into a non-standard setting key. This now picks up either place.

As @mattwire commented - perhaps we would be better to update all the saved settings on upgrade....

Comments

@monishdeb can you test this with your financial acls stuff - I picked it up trying out something on them

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

@eileenmcnaughton if @monishdeb isn't able to test what would you propose would be the way forward with this one

[eileenmcnaughton]

@seamuslee001 I'm pretty confident - it's similar to what we did with other half-mangled settings for the rc & I've checked locally

[monishdeb]

umm

\Civi::$statics[__CLASS__]['is_acl_enabled'] = Civi::settings()->get('acl_financial_type') ?: CRM_Utils_Array::value('acl_financial_type', Civi::settings()->get('contribution_invoice_settings'), FALSE);

?

[eileenmcnaughton]

I guess so but I kinda wanted to parse out the bit that should be deprecated / removed

[monishdeb]

Sorry for the delay, agree with the patch BUT how about that one-liner?

[eileenmcnaughton]

@monishdeb re the one-liner - I actually want to deprecate that handling for the 'not really set' & leaving it as an add on makes it easier to strip out.

I'm going to go ahead & merge this since you agree in principle & I want regressions in the rc fixed asap - We can tweak further in master but as @mattwire suggested actually transforming the settings makes sense