Fixes to enable UserDashboard tests to all run #13147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
eileenmcnaughton
force-pushed
the
dash_fix
branch
9 times, most recently
from
96d81fe to
e054d19
Compare
eileenmcnaughton
force-pushed
the
dash_fix
branch
14 times, most recently
from
321bd1f to
42b1069
Compare
eileenmcnaughton
force-pushed
the
dash_fix
branch
2 times, most recently
from
789c39a to
4d18783
Compare
eileenmcnaughton
force-pushed
the
dash_fix
branch
from
4d18783 to
e6507b1
Compare
|
I'm going to self-merge this because it only affects - and extends - tests -making Jenkins the real reviewer (& she was a harsh reviewer) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Test enhancements to cover user contribution dashboard
Before
Test skipped / missing as it wouldn't complete on jenkins (it would locally)
After
Tests passing
Technical Details
I added tests when I did an rc fix but couldn't get Jenkins to accept them - seems to be something in the $_REQUEST that isn't unset on jenkins.
Comments
I have some follow up code improvement once this is merged