Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#507 - Fix wrong version of jstree in search popop #13128

Merged
merged 1 commit into from
Nov 20, 2018

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Nov 19, 2018

Summary

Fixes https://lab.civicrm.org/dev/core/issues/507

Before

Tag popup doesn't work on search forms

After

Tag popup works on search forms

Technical details

The jstree library was upgraded a few versions back for tag screens. In this case we need to include the upgraded version on the search form as it is used for tags.

@civibot civibot bot added the 5.8 label Nov 19, 2018
@civibot
Copy link

civibot bot commented Nov 19, 2018

(Standard links)

@eileenmcnaughton
Copy link
Contributor

@colemanw lets do this against master - it's not a new regression I don't think - just something no-one noticed for a long time

@eileenmcnaughton
Copy link
Contributor

@pradpnayak ...

@colemanw colemanw changed the base branch from 5.8 to master November 19, 2018 21:16
@civibot civibot bot added master and removed 5.8 labels Nov 19, 2018
@seamuslee001
Copy link
Contributor

(CiviCRM Review Template WORD-1.1)

@seamuslee001
Copy link
Contributor

Adding merge on pass

@colemanw colemanw changed the base branch from master to 5.8 November 19, 2018 21:33
@civibot civibot bot added 5.8 and removed master labels Nov 19, 2018
@eileenmcnaughton
Copy link
Contributor

unrelated fail

@eileenmcnaughton eileenmcnaughton merged commit 349897c into civicrm:5.8 Nov 20, 2018
@mattwire
Copy link
Contributor

@colemanw Shouldn't this be jstree.min.js and not jquery.jstree.min.js? On both 5.7.2 and master I'm getting a 404 on advanced search because it's looking for the second one but it does not exist.

@colemanw
Copy link
Member Author

colemanw commented Nov 25, 2018

Whoops you're right. Actually, the script isn't needed at all! Let's just remove it and all will be well.
#13153

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants