-
-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dev/core#507 - Fix wrong version of jstree in search popop #13128
Conversation
(Standard links)
|
@colemanw lets do this against master - it's not a new regression I don't think - just something no-one noticed for a long time |
@pradpnayak ... |
Adding merge on pass |
unrelated fail |
@colemanw Shouldn't this be jstree.min.js and not jquery.jstree.min.js? On both 5.7.2 and master I'm getting a 404 on advanced search because it's looking for the second one but it does not exist. |
Whoops you're right. Actually, the script isn't needed at all! Let's just remove it and all will be well. |
Summary
Fixes https://lab.civicrm.org/dev/core/issues/507
Before
Tag popup doesn't work on search forms
After
Tag popup works on search forms
Technical details
The jstree library was upgraded a few versions back for tag screens. In this case we need to include the upgraded version on the search form as it is used for tags.