dev/core#532 Batch search fix

[pradpnayak]

Overview

https://lab.civicrm.org/dev/core/issues/532

Before

After

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

Yuck - this code is not nice. We really should be transforming the variables back in the AJAX call to the stand api format - and probably calling the api & eliminating that function altogether.

However, that line of thinking quickly leads to concluding we should replace that whole form with something based on more current approaches. Given we don't want to go that far :-) this seems like a sensible compromise and it DOES have a unit test.

I tested & was able to replicate both the fact of the bug & that this fixes.

Merge on pass - thanks @pradpnayak for finding & fixing this so efficiently

[seamuslee001]

Jenkins re test this please

[seamuslee001]

Jenkins re test this please

[eileenmcnaughton]

unrelated test fails - merging