Export class cleanup - remove some unnecessary code #13120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
eileenmcnaughton
force-pushed
the
less_primary
branch
from
e3cec82 to
c8de195
Compare
…KA all) fields In testing all these fields except for provider_id are already in the primary field. Provider ID is a psynonym for im_provider. Possibly it is the better name choice but it has a lot of hacks associated with it that can go by removing it
eileenmcnaughton
force-pushed
the
less_primary
branch
from
c8de195 to
7626754
Compare
|
test this please |
|
@eileenmcnaughton I've tested a contact export with and without this patch. As stated in the PR the "IM Service Provider" field is no longer exported, but it's a duplicate of "IM Provider" which is still exported. Ok to merge. |
|
thanks @mattwire |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Remove hard-coded add ons to 'primary' (AKA all) fields - these are already present & tested. The provider_id is actually a duplicate of im_provider and by removing it we get rid of some other hacks
Before
Unnecessary code present
After
Unnecessary code removed
Technical Details
These are being merged into an array that already contains them. The only one not already present is provider_id - but this exports the same data as im_provider
Comments
CRM_Export_BAO_ExportTest::testGetSQLColumnsAndHeaders covers this pretty thoroughly