Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix php7.2 notices on trying to count null #13111

Merged
merged 1 commit into from
Nov 16, 2018

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Fix warning messages in php 7.2 when trying to count NULL

Before

screenshot 2018-11-16 14 54 49

After

screenshot 2018-11-16 14 55 24

Technical Details

I just fixed all the places where these 2 smarty vars are counted as they are often NULL. There are a couple of other similar patterns but I don't know if they are potentially null so not addressing pro-actively

Comments

@seamuslee001 another one

@civibot
Copy link

civibot bot commented Nov 16, 2018

(Standard links)

@civibot civibot bot added the master label Nov 16, 2018
@monishdeb
Copy link
Member

Agree with the fix. Tested on local and didn't cause unintended behaivour. Thanks!

@monishdeb monishdeb merged commit 8bdae93 into civicrm:master Nov 16, 2018
@eileenmcnaughton eileenmcnaughton deleted the php72Countable branch November 16, 2018 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants