dev/core#527 Permit translation of Public Title field for Profiles #13110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
mattwire
approved these changes
Nov 16, 2018
There was a problem hiding this comment.
@eileenmcnaughton I've r-run this and done a code review. It works perfectly.
I have not tested this on a multilingual install and I don't quite understand how this makes the field translateable but I'm assuming that's part of the magic of entityform?
| @@ -112,6 +120,9 @@ | |||
| <type>int</type> | |||
| <required>true</required> | |||
| <default>1</default> | |||
| <html> | |||
| <type>Text</type> | |||
| </html> | |||
There was a problem hiding this comment.
Yes. All changes in UFGroup.xml are correct.
| 'description' => ts('Profile Form Public title'), | ||
| 'maxlength' => 64, | ||
| 'size' => CRM_Utils_Type::BIG, | ||
| 'table_name' => 'civicrm_uf_group', | ||
| 'entity' => 'UFGroup', | ||
| 'bao' => 'CRM_Core_BAO_UFGroup', | ||
| 'localizable' => 1, | ||
| 'html' => [ | ||
| 'type' => 'Text', | ||
| ], |
There was a problem hiding this comment.
Yes. All changes in UFGroup.php are correct.
| 'description' => ['name' => 'description', 'help' => ['id' => 'id-description', 'file' => 'CRM/UF/Form/Group.hlp']], | ||
| 'uf_group_type' => ['name' => 'uf_group_type', 'not-auto-addable' => TRUE, 'help' => ['id' => 'id-used_for', 'file' => 'CRM/UF/Form/Group.hlp'], 'post_html_text' => ' ' . $this->getOtherModuleString()] | ||
| ]; | ||
| } |
| $otherModuleString .= " [ x ] <label>" . $key . "</label>"; | ||
| } | ||
| $this->assign('otherModuleString', $otherModuleString); | ||
| } |
There was a problem hiding this comment.
Yes. Moved to it's own function getOtherModuleString()
| @@ -33,7 +33,7 @@ | |||
| {/capture}{help id=$help.id file=$help.file}{/if} | |||
| {if $action == 2 && $fieldSpec.is_add_translate_dialog}{include file='CRM/Core/I18n/Dialog.tpl' table=$entityTable field=$fieldName id=$entityID}{/if} | |||
There was a problem hiding this comment.
@mattwire this line ^^
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes the field 'Public Title' to be translatable on the profile form
Before
Not translatable
After
Technical Details
In order to fix this field I have partially converted the form to an EntityForm. To finish the form we probably need to figure out how to deal with the accordian in it - but I did look at one challenge - which was having a way to add some text after the html & before the
which I did in the tpl
Comments
@mattwire ping
@samuelsov this fixes one of the fields you describe in https://lab.civicrm.org/dev/core/issues/527
Note that the next field on the display is 'description' and that doesn't seem to be localised in the schema yet. I think there are some upgrade challenges in changing that