Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for issue-525: Extraneous br-tags in rendered note-fields #13101

Merged
merged 1 commit into from
Nov 16, 2018

Conversation

thomst
Copy link
Contributor

@thomst thomst commented Nov 15, 2018

Overview

This is a fix for issue-525 "Extraneous br-tags in rendered note-fields"

Before

Note-Fields were rendered with extraneous br-tags. Newlines are displayed doubly.

screenshot 2018-11-16 13 38 37

After

Note-Fields were not rendered with extraneous br-tags. Newlines are displayed once.
screenshot 2018-11-16 13 38 48

Technical Details

I simply removed the elseif-clause where memo-field-values were passed through the nl2br-filter within templates/CRM/Contact/Page/View/CustomDataFieldView.tpl

@civibot
Copy link

civibot bot commented Nov 15, 2018

(Standard links)

@civibot civibot bot added the master label Nov 15, 2018
@eileenmcnaughton
Copy link
Contributor

This makes sense from a code POV - the gitlab says this is already done in

CRM/Core/BAO/CustomField.php:1300

@eileenmcnaughton
Copy link
Contributor

I tested this & it works well - screenshots added into the description. I tried on a rich text & a textarea field. I also looked at the profile listings screen and it worked fine there too. I tried adding custom data to a participant & there seemed to be a bit much space - but not worse for this.

Merging

@eileenmcnaughton eileenmcnaughton merged commit 67c07fa into civicrm:master Nov 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants